[webkit-reviews] review granted: [Bug 57507] Clean up IndexedDB WebKit API : [Attachment 88054] manual upload

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Hans Wennborg <hans at chromium.org>'s
request for review:
Bug 57507: Clean up IndexedDB WebKit API
https://bugs.webkit.org/show_bug.cgi?id=57507

Attachment 88054: manual upload
https://bugs.webkit.org/attachment.cgi?id=88054&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88054&action=review

Thanks for picking up this change.  What was the bug with the old patch?

> Source/WebKit/chromium/ChangeLog:14
> +	   Second try: added WebCore:: qualifier to
> +	   injectIDBKeyIntoSerializedValue in WebIDBKey.cpp.

Usually we don't put this kind of information in ChangeLogs.  We usually put it
in bug comments because it's information about how the patch was produced, not
why the change is being made.

> Source/WebKit/chromium/src/WebIDBTransactionImpl.cpp:2
> - * Copyright (C) 2010 Google Inc. All rights reserved.
> + * Copyright (C) 2011 Google Inc. All rights reserved.

We probably shouldn't change just the copyright in this file.

> Source/WebKit/chromium/src/WebIDBTransactionImpl.h:2
> - * Copyright (C) 2010 Google Inc. All rights reserved.
> + * Copyright (C) 2011 Google Inc. All rights reserved.

Or this one.