[webkit-reviews] review granted: [Bug 55150] [Cairo] Better separate the concerns of GraphicsContextCairo : [Attachment 88107] Patch fixing issues with previous version

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 4 13:13:25 PDT 2011


Eric Seidel <eric at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 55150: [Cairo] Better separate the concerns of GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=55150

Attachment 88107: Patch fixing issues with previous version
https://bugs.webkit.org/attachment.cgi?id=88107&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88107&action=review

Looks sane to me.

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1208
> +    cairo_t* cr = platformContext()->cr();

seems you might want a cr() method on GraphicsContext itself give how often you
call this.


More information about the webkit-reviews mailing list