[webkit-reviews] review granted: [Bug 52058] setContentEditable with true/false/inherit string is not working properly : [Attachment 87145] fix patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 4 12:20:55 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Chang Shu <cshu at webkit.org>'s
request for review:
Bug 52058: setContentEditable with true/false/inherit string is not working
properly
https://bugs.webkit.org/show_bug.cgi?id=52058

Attachment 87145: fix patch 2
https://bugs.webkit.org/attachment.cgi?id=87145&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87145&action=review

r=me provided you make the following change to the change log entry.

> Source/WebCore/ChangeLog:10
> +	   checking editability: rendererIsEditable and isContentEdiable. The
former is a fast path,
> +	   which checks the render style of usermodify. The latter updates the
layout first to make

In addition to being fast, rendererIsEditable does NOT trigger layout, which is
an important thing in some call sites so you should probably mention that
although the function implies it.


More information about the webkit-reviews mailing list