[webkit-reviews] review granted: [Bug 56085] [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult : [Attachment 86906] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 56085: [Refactoring] SpellCheckingResult should be replaced with
TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085

Attachment 86906: Patch
https://bugs.webkit.org/attachment.cgi?id=86906&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86906&action=review

Thank you for the confirmation, Jia.

> Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.cpp:53
> +    switch (error) {
> +    case WebKit::WebTextCheckingResult::ErrorSpelling:
> +	   return TextCheckingTypeSpelling;
> +    case WebKit::WebTextCheckingResult::ErrorGrammar:
> +	   return TextCheckingTypeGrammar;
> +    default:
> +	   ASSERT_NOT_REACHED();
> +	   return TextCheckingTypeGrammar;
> +    }

You should also replace this with a if statement.