[webkit-reviews] review granted: [Bug 57749] Web Inspector: Highlighted search tokens would not be shown on long lines in the text viewer : [Attachment 88048] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 57749: Web Inspector: Highlighted search tokens would not be shown on long
lines in the text viewer
https://bugs.webkit.org/show_bug.cgi?id=57749

Attachment 88048: Patch
https://bugs.webkit.org/attachment.cgi?id=88048&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88048&action=review

> Source/WebCore/inspector/front-end/TextViewer.js:1029
> +	       if (this._rangeToMark && this._rangeToMark.startLine ===
lineNumber)

Consider refactoring this method and extracting syntax highlight and search
result highlight into separate methods.