[webkit-reviews] review granted: [Bug 56942] EventSource should only accept UTF-8 charset : [Attachment 88028] Same as previously - with a work-around for some PHP escaping issues

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 56942: EventSource should only accept UTF-8 charset
https://bugs.webkit.org/show_bug.cgi?id=56942

Attachment 88028: Same as previously - with a work-around for some PHP escaping
issues
https://bugs.webkit.org/attachment.cgi?id=88028&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88028&action=review

> LayoutTests/ChangeLog:21
> +	   in the URL. Also added a work-around a bug in PHP.

I don't think that it's a bug. A quick web search suggested that it's a
configuration option, and we should do something like:

if (get_magic_quotes_gpc()){
    $value = stripslashes($value);
}

See also: <http://php.net/manual/en/function.stripslashes.php>,
<http://php.net/manual/en/function.get-magic-quotes-gpc.php>.

Please use the proposed pattern, and fix the ChangeLog accordingly.

> LayoutTests/http/tests/eventsource/eventsource-content-type-charset.html:35
> +			'text/event-stream; charset=windows-1152',

Did you mean to use a non-existent charset here? If so, 1152 is an overly
subtle way to express that.

I think that we should test windows-1251 or us-ascii.