[webkit-reviews] review granted: [Bug 57527] WebKit2: No "open in preview" contextual menu item for PDFs : [Attachment 87678] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Apr 3 16:21:14 PDT 2011
mitz at webkit.org has granted Jer Noble <jer.noble at apple.com>'s request for
review:
Bug 57527: WebKit2: No "open in preview" contextual menu item for PDFs
https://bugs.webkit.org/show_bug.cgi?id=57527
Attachment 87678: Patch
https://bugs.webkit.org/attachment.cgi?id=87678&action=review
------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=87678&action=review
> Source/WebKit2/UIProcess/API/mac/PDFViewController.mm:62
> + CFURLRef appURL = nil;
Now that it’s a CF type, it should be = 0, not = nil.
> Source/WebKit2/UIProcess/API/mac/PDFViewController.mm:68
> + NSString *appPath = [(NSURL*)appURL path];
Need space after NSURL
More information about the webkit-reviews
mailing list