[webkit-reviews] review denied: [Bug 57715] Expclicitly use icu namespace for ports building with U_USING_ICU_NAMESPACE=0 : [Attachment 87993] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Apr 2 20:16:14 PDT 2011
Adam Barth <abarth at webkit.org> has denied Nico Weber <thakis at chromium.org>'s
request for review:
Bug 57715: Expclicitly use icu namespace for ports building with
U_USING_ICU_NAMESPACE=0
https://bugs.webkit.org/show_bug.cgi?id=57715
Attachment 87993: Patch
https://bugs.webkit.org/attachment.cgi?id=87993&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87993&action=review
> Source/WebCore/ChangeLog:12
> + Expclicitly use icu namespace for ports building with
U_USING_ICU_NAMESPACE=0
> + https://bugs.webkit.org/show_bug.cgi?id=57715
> +
> + * platform/text/LocalizedNumberICU.cpp:
> + (WebCore::createFormatterForCurrentLocale):
> + (WebCore::numberFormatter):
> + (WebCore::parseLocalizedNumber):
> + (WebCore::formatLocalizedNumber):
This ChangeLog doesn't tell me why you're making this change. I have no idea.
More information about the webkit-reviews
mailing list