[webkit-reviews] review granted: [Bug 57704] Remove AbstractStep._run_script and move script names to ports.py : [Attachment 87974] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 57704: Remove AbstractStep._run_script and move script names to ports.py
https://bugs.webkit.org/show_bug.cgi?id=57704

Attachment 87974: Patch
https://bugs.webkit.org/attachment.cgi?id=87974&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Sigh.  Well, this is a good thing to do, but there are two troubles I should
point outin this patch.  1.  ports.py should die.  class methods aren't
long-term scaleable.  We have a port.py over in layout_tests which we
eventually want to merge it with/replace it with.

Second, run_and_throw_if_fail also is deprecated and should die. :)

That said, this is a great change to get rid of a fixme!

I'm glad to see you workign on webkitpy!