[webkit-reviews] review requested: [Bug 57698] Web Inspector: introduce support of 'optional' flag for command arguments : [Attachment 87973] [patch] second version
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Apr 2 03:10:03 PDT 2011
Ilya Tikhonovsky <loislo at chromium.org> has asked for review:
Bug 57698: Web Inspector: introduce support of 'optional' flag for command
arguments
https://bugs.webkit.org/show_bug.cgi?id=57698
Attachment 87973: [patch] second version
https://bugs.webkit.org/attachment.cgi?id=87973&action=review
------- Additional Comments from Ilya Tikhonovsky <loislo at chromium.org>
test coverage was extended. See changes in report-API-errors.html,
report-protocol-errors.html and runtime-agent.html
optional arguments are transferred by const pointers.
simplest implementation for optional arguments was added to the setBreackpoint*
methods. I think we will fix that in another patch.
More information about the webkit-reviews
mailing list