[webkit-reviews] review denied: [Bug 57698] Web Inspector: introduce support of 'optional' flag for command arguments : [Attachment 87968] [patch] initial version

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 57698: Web Inspector: introduce support of 'optional' flag for command
arguments
https://bugs.webkit.org/show_bug.cgi?id=57698

Attachment 87968: [patch] initial version
https://bugs.webkit.org/attachment.cgi?id=87968&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87968&action=review

> LayoutTests/ChangeLog:5
> +	   Web Inspector: introduce support of 'optional' flag for command
arguments.

It is not clear from the ChangeLog / perl script what the behavior would be,
but here are the requirements as I see then:
1) it should be possible to make any number of parameters optional
2) optional parameters are the ones not transmitted as a part of the message
3) first parameter described could be made optional, not necessarily the last
one
4) there should be a way to distinguish between "columnNumber = 0" and "not
given optional columnNumber"

It sounds like (3) and (4) are not supported. Please explain what you intend to
do in the bug like this prior to working on the change to aoid further
confusion.