[webkit-reviews] review granted: [Bug 57662] new-run-webkit-tests: fix feature detection, skipped platform lists on mac : [Attachment 87941] update w/ feedback from abarth

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 1 17:45:58 PDT 2011


Adam Barth <abarth at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 57662: new-run-webkit-tests: fix feature detection, skipped platform lists
on mac
https://bugs.webkit.org/show_bug.cgi?id=57662

Attachment 87941: update w/ feedback from abarth
https://bugs.webkit.org/attachment.cgi?id=87941&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87941&action=review

> Tools/Scripts/webkitpy/layout_tests/port/mac.py:134
> +    def _path_to_webcore_library(self):
> +	   return self._build_path('WebCore.framework/Versions/A/WebCore')

I would have made this change in a separate patch, but i think it's fine to add
it to this patch.


More information about the webkit-reviews mailing list