[webkit-reviews] review granted: [Bug 57683] WK2 Icon Database API needs to be fleshed out : [Attachment 87945] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 1 17:35:32 PDT 2011


Darin Adler <darin at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 57683: WK2 Icon Database API needs to be fleshed out
https://bugs.webkit.org/show_bug.cgi?id=57683

Attachment 87945: Patch v1
https://bugs.webkit.org/attachment.cgi?id=87945&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87945&action=review

> Source/WebKit2/UIProcess/WebIconDatabase.cpp:208
> +{	

Stray whitespace crept in here.

> Source/WebKit2/UIProcess/WebIconDatabase.cpp:220
> +    RefPtr<WebURL> url = WebURL::create(pageURL);
> +    m_iconDatabaseClient.didChangeIconForPageURL(this, url.get());

I think this would read better without the local variable.


More information about the webkit-reviews mailing list