[webkit-reviews] review granted: [Bug 54230] [GTK] Implement WebPage class for WebKit2 : [Attachment 86969] Proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 54230: [GTK] Implement WebPage class for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54230

Attachment 86969: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=86969&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86969&action=review

Looks good. Please ensure that you have all the necessary WebPage stubs before
landing.

> Source/WebKit2/ChangeLog:1
> +2011-03-25  Amruth Raj  <amruthraj at motorola.com> and Ravi Phaneendra
Kasibhatla  <ravi.kasibhatla at motorola.com> and Alejandro G. Castro 
<alex at igalia.com>

Probably best to use First, Second, and here.

> Source/WebKit2/UIProcess/WebPageProxy.h:-586
> -    

I would restore this newline.

> Source/WebKit2/UIProcess/gtk/WebView.h:68
> +    // Keyboard events handling.

You can omit this coment.

> Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:42
> +						   m_page->pageID(),
CoreIPC::Connection::NoTimeout);

Does it make sense to require a timeout for this?