[webkit-reviews] review granted: [Bug 57670] Add adoptWK to WKRetainPtr.h : [Attachment 87929] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 57670: Add adoptWK to WKRetainPtr.h
https://bugs.webkit.org/show_bug.cgi?id=57670

Attachment 87929: Patch
https://bugs.webkit.org/attachment.cgi?id=87929&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87929&action=review

> Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h:207
> +template<typename T> static inline WKRetainPtr<T> adoptWK(const T o)

Is the const really helpful here? Won't all values of T be pointer types?

> Tools/TestWebKitAPI/PlatformUtilities.h:1
> -/*
> + /*

Whoopsie!