[webkit-reviews] review denied: [Bug 55074] [Qt][WK2] Build Webkit2 using "-2" option on Qt : [Attachment 87890] fix patch 2

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has denied Chang Shu <cshu at webkit.org>'s
request for review:
Bug 55074: [Qt][WK2] Build Webkit2 using "-2" option on Qt
https://bugs.webkit.org/show_bug.cgi?id=55074

Attachment 87890: fix patch 2
https://bugs.webkit.org/attachment.cgi?id=87890&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87890&action=review

The idea is great, but we can make it simpler.
Please fix it, and I'll r+ it.

> Tools/Scripts/build-webkit:308
> +    $noWebKit2 = !isWK2();
> +

Remove this line.

> Tools/Scripts/build-webkit:359
> +  -2 			       build WebKit2

It affects only the Qt port, "Build WebKit2 (Qt only)" would be better comment

> Tools/Scripts/build-webkit:511
> +    push @options, "--qmakearg=CONFIG+=webkit2" if !$noWebKit2;

push @options, "--qmakearg=CONFIG+=webkit2" if isWK2();