[webkit-reviews] review granted: [Bug 57528] WebKit2: Link from PDF opens in a new tab instead of in the same tab : [Attachment 87895] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 57528: WebKit2: Link from PDF opens in a new tab instead of in the same tab
https://bugs.webkit.org/show_bug.cgi?id=57528

Attachment 87895: Patch
https://bugs.webkit.org/attachment.cgi?id=87895&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87895&action=review

Seems OK. Might want to have Sam or Anders look at the “event with no type”
concept to be sure we want it.

> Source/WebKit2/UIProcess/API/mac/PDFViewController.mm:522
> +	   case NSLeftMouseUp:
> +	   case NSRightMouseUp:
> +	   case NSOtherMouseUp:
> +	       event = WebEventFactory::createWebMouseEvent(nsEvent,
m_pdfView);

WebKit coding style lines the case up with the switch.

I’d like to see a “why” comment explaining why it’s appropriate to pass an
empty event if the current event is not a mouse up event.