[webkit-reviews] review granted: [Bug 55191] rebaseline-chromium-webkit-tests doesn't handle GPU modifiers "correctly" : [Attachment 87891] update w/ review feedback from tony
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 1 11:58:01 PDT 2011
Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 55191: rebaseline-chromium-webkit-tests doesn't handle GPU modifiers
"correctly"
https://bugs.webkit.org/show_bug.cgi?id=55191
Attachment 87891: update w/ review feedback from tony
https://bugs.webkit.org/attachment.cgi?id=87891&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87891&action=review
> Tools/ChangeLog:16
> + This change removes the -g and -w flags. The -g flag is gone
Nit: removes -w to deprecates -w.
> Tools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:443
> + lineno = 0
> + lines = []
> + for line in self._get_iterable_expectations(self._expectations):
> + lineno += 1
Nit: enumerate()
More information about the webkit-reviews
mailing list