[webkit-reviews] review granted: [Bug 56904] [EFL] Update signals description : [Attachment 87672] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 1 11:21:05 PDT 2011

Antonio Gomes <tonikitoo at webkit.org> has granted Grzegorz
<g.czajkowski at samsung.com>'s request for review:
Bug 56904: [EFL] Update signals description

Attachment 87672: patch

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87672&action=review

It looks fine, but might need an extra interaction. If ProFusion guys want to
validate, it would be know.

> Source/WebKit/efl/ewk/ewk_contextmenu.h:29
> + *  - "contextmenu,free", Ewk_Context_Menu *: a context menu is freed.

freed. Would hidden be better?

> Source/WebKit/efl/ewk/ewk_view.h:77
> + *  - "link,hover,in", const char *link[2]: reports mouse is over a link
> + *	 it gives the url in link[0] and link's title in link[1] as an

I think there could be a period between these two lines.

> Source/WebKit/efl/ewk/ewk_view.h:91
> + *  - "tooltip,text,set", const char*: sets tooltip text and display if it
is currently hidden.


More information about the webkit-reviews mailing list