[webkit-reviews] review granted: [Bug 57618] [GTK] Main loop sources are leaked in RunLoopGtk : [Attachment 87847] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 57618: [GTK] Main loop sources are leaked in RunLoopGtk
https://bugs.webkit.org/show_bug.cgi?id=57618

Attachment 87847: Patch
https://bugs.webkit.org/attachment.cgi?id=87847&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87847&action=review

Great work. Please consider the method name changes below before landing.

> Source/WebKit2/Platform/gtk/RunLoopGtk.cpp:95
> +void RunLoop::TimerBase::reset()

I think the name clearTimerSource better describes what this one does.

> Source/WebKit2/Platform/gtk/RunLoopGtk.cpp:100
> +void RunLoop::TimerBase::resetTimerSource(RunLoop::TimerBase* timer)

Please call this one destroyNotifyCallback to make it clear that this is just
used as a callback.

> Source/WebKit2/Platform/gtk/RunLoopGtk.cpp:105
> +gboolean RunLoop::TimerBase::timerFired(RunLoop::TimerBase* timer)

Please call this one timerFiredCallback.