[webkit-reviews] review denied: [Bug 57548] Web Inspector: Separate sendMessageToFrontend function from InspectorClient to individual interface : [Attachment 87846] Patch, separated sendMessageToFrontend from InspectorClient

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Sergey Vorobyev
<sergeyvorobyev at google.com>'s request for review:
Bug 57548: Web Inspector: Separate sendMessageToFrontend function from
InspectorClient to individual interface
https://bugs.webkit.org/show_bug.cgi?id=57548

Attachment 87846: Patch, separated sendMessageToFrontend from InspectorClient
https://bugs.webkit.org/attachment.cgi?id=87846&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87846&action=review

> Source/WebCore/WebCore.gypi:3224
> +	       'inspector/InspectorFrontendChannel.h',

Mind alphabetic order.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:22772
> +				227777601345DEA9008EA455 /*
InspectorFrontendChannel.h in Headers */,

Other headers in this section seem to be sorted, please keep the order.

> Source/WebCore/inspector/CodeGeneratorInspector.pm:100
> +$typeTransform{"InspectorFrontendChannel"} = {

I think may not need "InspectorClient" forward declaration and header import
anymore, please check and remove corresponding code from the generator if it is
so.

> Source/WebCore/inspector/InspectorClient.h:29
> +#include "InspectorFrontendChannel.h"

Please add  Copyright (C) 2011 Google Inc.... header to the license above since
you're modifying this file.