[webkit-reviews] review denied: [Bug 46955] [Chromium] build fails unless ACCELERATED_2D_CANVAS defined : [Attachment 69421] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 30 22:02:09 PDT 2010
James Robinson <jamesr at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 46955: [Chromium] build fails unless ACCELERATED_2D_CANVAS defined
https://bugs.webkit.org/show_bug.cgi?id=46955
Attachment 69421: Patch
https://bugs.webkit.org/attachment.cgi?id=69421&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
Thanks for cleaning this up. Needs a few things, though:
ENABLE(ACCELERATED_2D_CANVAS), not ENABLE(ENABLE_ACCELERATED_2D_CANVAS).
The ASSERT()s and NOT_REACHED() are unnecessary, those functions should just be
no-ops if the ENABLE() isn't set.
More information about the webkit-reviews
mailing list