[webkit-reviews] review denied: [Bug 46949] Event names should always match the registered handler : [Attachment 69407] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Enrica Casucci <enrica at apple.com>'s request for
review:
Bug 46949: Event names should always match the registered handler
https://bugs.webkit.org/show_bug.cgi?id=46949

Attachment 69407: Patch
https://bugs.webkit.org/attachment.cgi?id=69407&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=69407&action=review

>>> WebCore/dom/EventTarget.cpp:310
>>> +		 event->useAliasedType();
>> 
>> Would it make sense to have event->type() have this logic?  Are there any
other places where using the regular type for an event with an aliased type
would cause problems?
> 
> It seems like alias is only used for focusin / focusout right now but are we
sure we want to use the aliased type whenever an event is aliased?  i.e. if we
are adding another aliased event in the future, do we also want to use the
aliased type for that?

I think it is wrong for the first target to change the event’s reported type
for all subsequent targets that might handle the same event.