[webkit-reviews] review denied: [Bug 46939] [chromium] Give WebString an operator<< when building unit tests : [Attachment 69389] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 30 15:13:37 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Nico Weber
<thakis at chromium.org>'s request for review:
Bug 46939: [chromium] Give WebString an operator<< when building unit tests
https://bugs.webkit.org/show_bug.cgi?id=46939

Attachment 69389: Patch
https://bugs.webkit.org/attachment.cgi?id=69389&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
I'm not thrilled about using he UNIT_TEST macro in WebKit API headers.	I'm OK
with this change otherwise, but I wonder... is #include <iosfwd> really enough
to support the implementation of this function?


More information about the webkit-reviews mailing list