[webkit-reviews] review granted: [Bug 46550] [chromium] Changes to consolidate plugin zoom : [Attachment 69265] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 30 13:04:45 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted John
Abd-El-Malek <jam at chromium.org>'s request for review:
Bug 46550: [chromium] Changes to consolidate plugin zoom
https://bugs.webkit.org/show_bug.cgi?id=46550
Attachment 69265: Patch
https://bugs.webkit.org/attachment.cgi?id=69265&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69265&action=review
> WebKit/chromium/public/WebPluginContainer.h:82
> + virtual void zoomChanged(double factor) = 0;
can this also pass zoom level? maybe name zoomLevelChanged
> WebKit/chromium/src/WebPluginContainerImpl.cpp:354
> +
nit: extra new line
R=me with those changes
More information about the webkit-reviews
mailing list