[webkit-reviews] review granted: [Bug 41571] [Qt] Fix http/tests/loading/redirect-methods.html : [Attachment 68951] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 30 11:19:03 PDT 2010


Adam Barth <abarth at webkit.org> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 41571: [Qt] Fix http/tests/loading/redirect-methods.html
https://bugs.webkit.org/show_bug.cgi?id=41571

Attachment 68951: Patch
https://bugs.webkit.org/attachment.cgi?id=68951&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68951&action=review

Looks great!  Thanks.

> WebCore/platform/network/qt/QNetworkReplyHandler.cpp:393
> +	   if ((statusCode >= 301 && statusCode <= 303) && 
m_resourceHandle->firstRequest().httpMethod() == "POST")

You've got an extra space in "&&  m_resourceHandle"


More information about the webkit-reviews mailing list