[webkit-reviews] review granted: [Bug 46854] new-run-webkit-tests: the Google Chrome port should be able to have its own test expectations overrides : [Attachment 69292] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 46854: new-run-webkit-tests: the Google Chrome port should be able to have
its own test expectations overrides
https://bugs.webkit.org/show_bug.cgi?id=46854

Attachment 69292: Patch
https://bugs.webkit.org/attachment.cgi?id=69292&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69292&action=review

LGTM with the try/catch removed.

> WebKitTools/Scripts/webkitpy/layout_tests/port/google_chrome.py:40
> +    except AssertionError:
> +	   # FIXME: this doesn't seem to get raised after r60427, but it
probably
> +	   # should still be possible.

If it's not possible for this to be raised, we should remove it for now.  Once
we add back the AssertionError, we can put this code back.