[webkit-reviews] review canceled: [Bug 46624] Web Inspector: implement pausing on event listeners (back-end part) : [Attachment 69336] Comments addressed.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has canceled Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 46624: Web Inspector: implement pausing on event listeners (back-end part)
https://bugs.webkit.org/show_bug.cgi?id=46624

Attachment 69336: Comments addressed.
https://bugs.webkit.org/attachment.cgi?id=69336&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69336&action=review

> WebCore/inspector/InspectorDebuggerAgent.cpp:-319
> -    if (!s_debuggerAgentOnBreakpoint)

Why are you deleting this code?

> WebCore/inspector/InspectorDebuggerAgent.h:70
> +    void schedulePauseOnNextStatement(DebuggerEventType type,
PassRefPtr<InspectorValue> data);

setPauseOnNextStatement?

> WebCore/inspector/InspectorInstrumentation.cpp:159
> +    timelineAgentsStack().append(std::make_pair(s_callDepth, 0));

Looks like too much code... Will we need to do it for every will/did pair?