[webkit-reviews] review denied: [Bug 46825] build fails if NETSCAPE_PLUGIN_API is disabled : [Attachment 69228] Patch for Page.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 30 08:13:55 PDT 2010


Anders Carlsson <andersca at apple.com> has denied sccameron at rim.com's request for
review:
Bug 46825: build fails if NETSCAPE_PLUGIN_API is disabled
https://bugs.webkit.org/show_bug.cgi?id=46825

Attachment 69228: Patch for Page.cpp
https://bugs.webkit.org/attachment.cgi?id=69228&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
I think the #if ENABLE needs to go inside the function body, otherwise the code
in Settings.cpp that tries to call it will fail.


More information about the webkit-reviews mailing list