[webkit-reviews] review requested: [Bug 46886] [GTK] Crash on testatk.c unittest because of a call to ASSERT_NOT_REACHED : [Attachment 69325] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 46886: [GTK] Crash on testatk.c unittest because of a call to
ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=46886

Attachment 69325: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=69325&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Attaching a patch proposal that just gets rid of the ASSERT_NOT_REACHED()
statement, as it's my understanding that's no longer correct. As explained in
the ChangeLog entry:

	So far, this assertion made sense because it was not possible that
	a call to listMarkerSuffix() happened when the style of the list
	item was one of the following: Asterisks, Circle, Discm Footnotes,
	NoneListStyle or Square (it's easy to figure this out by checking
	the functions where listMarkerSuffix() was called).

	However, since revision 68415 (about bug 45381), there's a new
	place where listMarkerSuffix() is being called (the suffix()
	public method), regardless of the style of the item being or not
	one of those pointed out, so the aforementioned assertion in
	listMarkerSuffix() would no longer be correct, as now it's ok to
	reach those cases in the switch statement.


Daniel, would you mind taking a look to this. I guess you're probably one of
the best persons to say whether this approach is correct or not.

Thanks in advance