[webkit-reviews] review granted: [Bug 43499] WebKit2 on Windows should use Windows fonts for the various standard font families : [Attachment 69299] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Jon Honeycutt
<jhoneycutt at apple.com>'s request for review:
Bug 43499: WebKit2 on Windows should use Windows fonts for the various standard
font families
https://bugs.webkit.org/show_bug.cgi?id=43499

Attachment 69299: Patch
https://bugs.webkit.org/attachment.cgi?id=69299&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69299&action=review

> WebKitTools/WebKitTestRunner/TestController.cpp:216
> +    static WKStringRef standardFontFamily =
WKStringCreateWithCFString(CFSTR("Times"));
> +    static WKStringRef cursiveFontFamily =
WKStringCreateWithCFString(CFSTR("Apple Chancery"));
> +    static WKStringRef fantasyFontFamily =
WKStringCreateWithCFString(CFSTR("Papyrus"));
> +    static WKStringRef fixedFontFamily =
WKStringCreateWithCFString(CFSTR("Courier"));
> +    static WKStringRef sansSerifFontFamily =
WKStringCreateWithCFString(CFSTR("Helvetica"));
> +    static WKStringRef serifFontFamily =
WKStringCreateWithCFString(CFSTR("Times"));

This is going to upset people in bug 45393, but there's no other way right now.