[webkit-reviews] review denied: [Bug 46518] need access info from WebInputEvent : [Attachment 69253] resotre info from currentInputEvent only when it exists

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied  review:
Bug 46518: need access info from WebInputEvent
https://bugs.webkit.org/show_bug.cgi?id=46518

Attachment 69253: resotre info from currentInputEvent only when it exists
https://bugs.webkit.org/attachment.cgi?id=69253&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69253&action=review

> WebKit/chromium/ChangeLog:5
> +	   Need access info direct from WebInputEvent.

please insert a link to this bug report here.

also, please revise the description of this change to better reflect what is
being done in the code.

> WebKit/chromium/src/WebPluginContainerImpl.cpp:450
> +	   static_cast<const
WebKeyboardEvent*>(WebViewImpl::currentInputEvent());

how do you know that this is a WebKeyboardEvent?

> WebKit/chromium/src/WebPluginContainerImpl.cpp:453
> +    if (currentInputEvent) {

Should you also validate that the currentInputEvent is a WebKeyboardEvent? 
During
the dispatch of another type of event, JS might dispatch a synthetic
KeyboardEvent.

in the future, please remember to set the '?' flag on the "review" field when
attaching your patch.  Otherwise, people won't know to look at your patch for
review.