[webkit-reviews] review granted: [Bug 46866] webkit-patch failure-reason dies if non-trunk commits are in the blame range : [Attachment 69301] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 29 20:01:19 PDT 2010


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 46866: webkit-patch failure-reason dies if non-trunk commits are in the
blame range
https://bugs.webkit.org/show_bug.cgi?id=46866

Attachment 69301: Patch
https://bugs.webkit.org/attachment.cgi?id=69301&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69301&action=review

> WebKitTools/Scripts/webkitpy/tool/mocktool.py:452
> +	   # The real Checkout would probably throw an exception, but this is
the only way tests have to get None back at the moment.
> +	   if not svn_revision:
> +	       return None

???


More information about the webkit-reviews mailing list