[webkit-reviews] review denied: [Bug 45773] Add isMainFrame flag to scroll functions : [Attachment 67592] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 29 19:48:04 PDT 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied João Paulo Rechi
Vita <jprvita at profusion.mobi>'s request for review:
Bug 45773: Add isMainFrame flag to scroll functions
https://bugs.webkit.org/show_bug.cgi?id=45773

Attachment 67592: Patch
https://bugs.webkit.org/attachment.cgi?id=67592&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=67592&action=review

I don't really understand why this is needed, and as such I cannot say if this
is the best way of accomplishing what you are trying to do.

r- for this reason.

> WebCore/ChangeLog:8
> +	   This information is needed by the new EFL tiled backing store.

This would probably need more explanation. Why is that needed for the EFL tiled
backing store. - you should explain that instead

> WebCore/loader/EmptyClients.h:151
> +    virtual void invalidateContentsForSlowScroll(const IntSize&, const
IntRect&, bool, bool) {};
> +    virtual void scroll(const IntSize&, const IntRect&, const IntRect&,
bool) { }

We are trying to more away from bool arguments. Consider using enums instead.


More information about the webkit-reviews mailing list