[webkit-reviews] review denied: [Bug 46854] new-run-webkit-tests: the Google Chrome port should be able to have its own test expectations overrides : [Attachment 69281] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 46854: new-run-webkit-tests: the Google Chrome port should be able to have
its own test expectations overrides
https://bugs.webkit.org/show_bug.cgi?id=46854

Attachment 69281: Patch
https://bugs.webkit.org/attachment.cgi?id=69281&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69281&action=review

r- because of unittests, but the approach seems fine.

> WebKitTools/Scripts/webkitpy/layout_tests/port/google_chrome.py:39
> +    except AssertionError:
> +	   # FIXME: when does this get raised?

This probably gets raised in a pure webkit checkout which doesn't have a
chromium base (I think path_from_chromium_base raises it).

> WebKitTools/Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:54
> +	   # FIXME: make this more robust when we have the Tree() abstraction.
> +	   # we should be able to test for the files existing or not, and

I don't like this test because it uses the current checked in files.  Can you
just call _test_expectations_overrides directly and pass in mock objects
instead?