[webkit-reviews] review denied: [Bug 46850] Wire GetGraphicsResetStatusARB from ARB_robustness extension in GraphicsContext3D : [Attachment 69279] Patch

[bugzilla-daemon at webkit.org]

Chris Marrin <cmarrin at apple.com> has denied Alexey Marinichev
<amarinichev at chromium.org>'s request for review:
Bug 46850: Wire GetGraphicsResetStatusARB from ARB_robustness extension in
GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=46850

Attachment 69279: Patch
https://bugs.webkit.org/attachment.cgi?id=69279&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69279&action=review

> WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:1456
> +

I don't understand the point of this patch. It doesn't hook anything up. It
simply adds placeholders. You should do at least one implementation to show
that it actually works, along with a test case with a bad shader that will
crash if ARB_robustness is not there.

I understand if this is just a stepping stone to that goal. But this bug is for
"hooking up" the extension, which this patch doesn't do.