[webkit-reviews] review granted: [Bug 46842] Add removeRecursively to WebKit WebFileSystem API : [Attachment 69255] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 29 17:22:00 PDT 2010


Dumitru Daniliuc <dumi at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 46842: Add removeRecursively to WebKit WebFileSystem API
https://bugs.webkit.org/show_bug.cgi?id=46842

Attachment 69255: Patch
https://bugs.webkit.org/attachment.cgi?id=69255&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69255&action=review

r=me.

> WebKit/chromium/public/WebFileSystem.h:69
> +    virtual void removeRecursively(const WebString& path,
WebFileSystemCallbacks*) { WEBKIT_ASSERT_NOT_REACHED(); }

const WebString& path: might have to remove the name of the argument for now,
or some compilers might complain that it's not used.


More information about the webkit-reviews mailing list