[webkit-reviews] review granted: [Bug 46852] Build fix: Add ENABLE(INSPECTOR) guard : [Attachment 69274] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 29 16:37:08 PDT 2010


Darin Adler <darin at apple.com> has granted Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 46852: Build fix: Add ENABLE(INSPECTOR) guard
https://bugs.webkit.org/show_bug.cgi?id=46852

Attachment 69274: Patch
https://bugs.webkit.org/attachment.cgi?id=69274&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Seems this would be better if you wrapped even more of the function in the #if.
It’s strange to look up a page to just return 0.


More information about the webkit-reviews mailing list