[webkit-reviews] review requested: [Bug 46839] Autocorrection shouldn't prompt the same correction after user has edited previous correction. : [Attachment 69260] Proposed patch (v1)

[bugzilla-daemon at webkit.org]

jpu at apple.com has asked  for review:
Bug 46839: Autocorrection shouldn't prompt the same correction after user has
edited previous correction.
https://bugs.webkit.org/show_bug.cgi?id=46839

Attachment 69260: Proposed patch (v1)
https://bugs.webkit.org/attachment.cgi?id=69260&action=review

------- Additional Comments from jpu at apple.com
Prior to bug 45709. We use "Replacement" marker to indicate the word that has
been autocorrected and need to be marked with underline. Whenever user edits an
autocorrected word, in order to remove the underline, we remove the
"Replacement" marker. However, doing this also prevents us from keeping track
of on which word we have already applied autocorrection. So if the user
corrects an autocorrection, we would keep prompting the same autocorrection
suggestion.

In bug 45709, we introduced a new marker "CorrectionIndicator" to indicate
whether we should draw underline. So now we can remove underline by removing
"CorrectionIndicator" marker. This allows us to keep "Replacement" marker
around, so that we won't suggest autocorrection on word that already bears
"Replacement" marker.