[webkit-reviews] review granted: [Bug 46563] Fix DirectoryReader's behavior to trigger only one EntriesCallback per readEntries : [Attachment 69215] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 46563: Fix DirectoryReader's behavior to trigger only one EntriesCallback
per readEntries
https://bugs.webkit.org/show_bug.cgi?id=46563

Attachment 69215: Patch
https://bugs.webkit.org/attachment.cgi?id=69215&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69215&action=review

PLease consider fixing the following before landing this change.

> LayoutTests/fast/filesystem/resources/fs-test-util.js:18
> +// FIXME: replace this with the API's one once the backend fully supports
removeRecursively.

I had a hard time understanding this comment. Is this the same idea?

// FIXME: replace this code with the equivalent File API method once the it
fully supports removeRecursively.

> WebCore/fileapi/DirectoryReader.h:45
> +class EntriesCallbacks;

Please sort.

> WebCore/fileapi/FileSystemCallbacks.cpp:167
> +	   m_directoryReader->setHasMore(hasMore);

Why is this call only done if m_successCallback is set? It seems like it should
always be done.