[webkit-reviews] review denied: [Bug 46834] Limit number of AudioNode deletions per render quantum in AudioContext : [Attachment 69242] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 46834: Limit number of AudioNode deletions per render quantum in
AudioContext
https://bugs.webkit.org/show_bug.cgi?id=46834

Attachment 69242: Patch
https://bugs.webkit.org/attachment.cgi?id=69242&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69242&action=review

There are several changes in this patch unrelated to this bug that need to be
removed.

> WebCore/webaudio/AudioContext.cpp:110
> +    m_hrtfDatabaseLoader =
HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary(sampleRate());

This is an unrelated change.

> WebCore/webaudio/AudioContext.cpp:351
> +	   m_graphOwnerThread = thisThread;

This also looks like an unrelated change.

> WebCore/webaudio/AudioContext.cpp:438
> +    ASSERT(isAudioThread() && isGraphOwner());

Is this new assertion related to this change?

> WebCore/webaudio/AudioContext.h:248
> +    RefPtr<HRTFDatabaseLoader> m_hrtfDatabaseLoader;

Unrelated changes shouldn't be in this patch.