[webkit-reviews] review granted: [Bug 46324] REGRESSION: page reload on back button after history.pushState with appearing/disappearing iframes : [Attachment 69016] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 46324: REGRESSION: page reload on back button after history.pushState with
appearing/disappearing iframes
https://bugs.webkit.org/show_bug.cgi?id=46324

Attachment 69016: Patch
https://bugs.webkit.org/attachment.cgi?id=69016&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69016&action=review

> WebCore/history/HistoryItem.cpp:494
> +// - The other item corresponds to the same document (for history entries
created via pushState or fragment changes).

this comment doesn't seem to really match the code.  based on this comment, i
expected to see hasSameDocumentTree called in cases where the
documentSequenceNumbers differ.