[webkit-reviews] review granted: [Bug 45657] Web Inspector: [Resources panel]=?UTF-8?Q?=20Need=20more=20visible=20=E2=80=9Cat=20a=20glance=E2=80=9D?=. : [Attachment 69224] [PATCH] Sorting by timeline + filter + nicer detailed view.

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 45657: Web Inspector: [Resources panel] Need more visible “at a glance”.
https://bugs.webkit.org/show_bug.cgi?id=45657

Attachment 69224: [PATCH] Sorting by timeline + filter + nicer detailed view.
https://bugs.webkit.org/attachment.cgi?id=69224&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69224&action=review

> WebCore/inspector/front-end/DataGrid.js:84
> +	   if (column.titleInnerHTML)

It would be nicer/safer if this was "titleDOMFragment" and used DOM fragments
insteast of raw HTML.

> WebCore/inspector/front-end/DataGrid.js:705
> +	       this._sortColumnCell.removeStyleClass("sort-ascending");

You could use removeMatchingStyleClasses("sort-\w+")

> WebCore/inspector/front-end/NetworkPanel.js:98
> +	   columns.url.titleInnerHTML =
this._makeHeaderInnerHTML(WebInspector.UIString("URL"),
WebInspector.UIString("Path"));

I think "Name" would be better than URL since we don't show the whole URL.

> WebCore/inspector/front-end/NetworkPanel.js:140
> +	   return title + "<div class='network-header-subtitle'>" + subtitle +
"</div>";

This code needs to escape the titles to be safe: title.escapeHTML()