[webkit-reviews] review granted: [Bug 38805] [Qt] Add PlainTextController to DRT : [Attachment 67834] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 29 10:56:52 PDT 2010
Andreas Kling <andreas.kling at nokia.com> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 38805: [Qt] Add PlainTextController to DRT
https://bugs.webkit.org/show_bug.cgi?id=38805
Attachment 67834: Patch
https://bugs.webkit.org/attachment.cgi?id=67834&action=review
------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=67834&action=review
> WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:758
> +QString DumpRenderTreeSupportQt::plainText(const QVariant& rng)
Variable naming, "rng" should be "range"
LGTM otherwise.
More information about the webkit-reviews
mailing list