[webkit-reviews] review granted: [Bug 46092] Web Inspector: display headers actually used by network stack in Resources tab : [Attachment 69201] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 46092: Web Inspector: display headers actually used by network stack in
Resources tab
https://bugs.webkit.org/show_bug.cgi?id=46092

Attachment 69201: patch
https://bugs.webkit.org/attachment.cgi?id=69201&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69201&action=review

> WebCore/WebCore.vcproj/WebCore.vcproj:27431
> +				       
RelativePath="..\platform\network\ResourceRawHeaders.h"

You should add new files to Xcode project.

> WebKit/chromium/public/WebResourceRawHeaders.h:38
> +class ResourceResponse;

mind import order.

> WebKit/chromium/public/WebResourceRawHeaders.h:50
> +    class HeadersMap {

Having addRequestHeader and addResponseHeader would look much more elegant.

> WebKit/chromium/public/WebResourceRawHeaders.h:62
> +    private:

remove this line.

> WebKit/chromium/src/WebResourceRawHeaders.cpp:79
> +    m_private->responseHeaders = *(const WebCore::HTTPHeaderMap*)value;

Can you do static cast here?