[webkit-reviews] review denied: [Bug 46518] need access info from WebInputEvent : [Attachment 68782] added missing header file

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied  review:
Bug 46518: need access info from WebInputEvent
https://bugs.webkit.org/show_bug.cgi?id=46518

Attachment 68782: added missing header file
https://bugs.webkit.org/attachment.cgi?id=68782&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68782&action=review

I think the plan, which I originally suggested to Brett, is flawed.  It is not
sufficient to rely on currentInputEvent like this.

> WebKit/chromium/src/WebPluginContainerImpl.cpp:449
> +	   static_cast<const
WebKeyboardEvent*>(WebViewImpl::currentInputEvent());

I think this will crash if JavaScript on the page programmatically generates a
KeyboardEvent.