[webkit-reviews] review denied: [Bug 46092] Web Inspector: display headers actually used by network stack in Resources tab : [Attachment 69186] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 46092: Web Inspector: display headers actually used by network stack in
Resources tab
https://bugs.webkit.org/show_bug.cgi?id=46092

Attachment 69186: patch
https://bugs.webkit.org/attachment.cgi?id=69186&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69186&action=review

> WebKit/chromium/public/WebResourceRawHeaders.h:37
> +namespace WebCore {

#if WEBKIT_IMPLEMENTATION

> WebKit/chromium/public/WebResourceRawHeaders.h:62
> +	   WebCore::HTTPHeaderMap* m_private;

Please use generic WebPrivatePtr instead.

> WebKit/chromium/public/WebURLResponse.h:87
> +    WEBKIT_API WebResourceRawHeaders* resourceRawHeaders();

setter, please

> WebKit/chromium/public/WebURLResponse.h:176
> +    WebPrivateOwnPtr<WebResourceRawHeaders> m_resourceRawHeaders;

WebPrivateOwnPtr is used to map to WebCore, you are simply pointing to public
WebKit api class here.