[webkit-reviews] review granted: [Bug 46764] Record bot ID when updating queue status : [Attachment 69149] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 46764: Record bot ID when updating queue status
https://bugs.webkit.org/show_bug.cgi?id=46764

Attachment 69149: Patch
https://bugs.webkit.org/attachment.cgi?id=69149&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69149&action=review

The one think I would change is that we should forward the bot_id to the child
process in run_webkit_patch (or wherever we forward the status_host).

> WebKitTools/Scripts/webkitpy/common/net/statusserver_unittest.py:42
> +    def setUp(self):
> +	   self.output_capture = OutputCapture()
> +	   self.output_capture.capture_output()
> +
> +    def tearDown(self):
> +	   self.output_capture.restore_output()

Should we put this code in a base class?  Maybe in the outputcapture package?

> WebKitTools/Scripts/webkitpy/tool/main.py:63
> +	   make_option("--bot-id", action="store", dest="bot_id",
type="string", help="Identifier for this bot (if multiple bots are running for
a queue)"),

Should this be a global option or an option on AbstractQueue?  I guess it makes
sense as a global option in case we need to pass it to commands along with
status_host.