[webkit-reviews] review requested: [Bug 42815] getBoundingClientRect Broken for SVG Elements : [Attachment 69153] Fix and layout test for zoomed elements

[bugzilla-daemon at webkit.org]

Cosmin Truta <ctruta at chromium.org> has asked  for review:
Bug 42815: getBoundingClientRect Broken for SVG Elements
https://bugs.webkit.org/show_bug.cgi?id=42815

Attachment 69153: Fix and layout test for zoomed elements
https://bugs.webkit.org/attachment.cgi?id=69153&action=review

------- Additional Comments from Cosmin Truta <ctruta at chromium.org>
getBoundingClientRect finally works correctly with zooming.

There are still off-by-one errors when zoomed arbitrarily. I'm pretty sure
that's because the bounding rectangle is adjusted for absolute zoom *after* it
is converted to IntRect. The roundoff errors are significant enough to cause
off-by-one, and sometimes even off-by-two errors from time to time. The layout
test that I included is okay, though, because zooming is done at well-behaved
ratios (50% and 200%).

I placed the layout test in the css3/ directory, rather than in an svg/
subdirectory, because I discovered that the zoom attribute hasn't been tested
with getBoundingC..., not even for HTML elements.