[webkit-reviews] review denied: [Bug 46771] GraphicsContext3D.cpp files are confusing : [Attachment 69148] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 28 18:35:40 PDT 2010


Kenneth Russell <kbr at google.com> has denied Alexey Marinichev
<amarinichev at chromium.org>'s request for review:
Bug 46771: GraphicsContext3D.cpp files are confusing
https://bugs.webkit.org/show_bug.cgi?id=46771

Attachment 69148: Patch
https://bugs.webkit.org/attachment.cgi?id=69148&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
You need to take into consideration that
platform/graphics/GraphicsContext3D.cpp is currently compiled in to all
platforms. You will minimally need to also modify
WebCore/WebCore.xcodeproj/project.pbxproj . I don't know whether you need to
strictly make this modification in Xcode or whether you can do it in a text
editor. You should also do a recursive grep on all flat files in the WebKit
workspace to see where else this file name is referenced. Since the bots
apparently can't build on Mac unless you're a WebKit committer I strongly
suggest testing your build modifications on Mac OS X -- or your reviewer will
need to do so for safety.


More information about the webkit-reviews mailing list